.janno & .ssf field parsing depending on a package's Poseidon version#364
Merged
nevrome merged 9 commits intoposeidon300colsfrom Jan 18, 2026
Merged
.janno & .ssf field parsing depending on a package's Poseidon version#364nevrome merged 9 commits intoposeidon300colsfrom
nevrome merged 9 commits intoposeidon300colsfrom
Conversation
…s depending on the poseidon package version
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## poseidon300cols #364 +/- ##
===================================================
- Coverage 57.34% 55.68% -1.67%
===================================================
Files 33 33
Lines 5228 5237 +9
Branches 552 632 +80
===================================================
- Hits 2998 2916 -82
- Misses 1678 1689 +11
- Partials 552 632 +80 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
My understanding of this mechanism is developing at a glacial speed, but today I made another breakthrough. I realized that I can replace cassava's
FromFieldtypeclass with my own. This allows to pass any desired piece of information down to the individual field parsers. For example the Poseidon version!I think I can use this to solve some things that have been bugging me about #357.