accept group shares with federated manager#4
Conversation
navid-shokri
left a comment
navid-shokri
left a comment
There was a problem hiding this comment.
it needs refactoring to become more straightforward.
| $f = $this->uid; | ||
| $externalGroupManager = new \OCA\FederatedGroups\FilesSharing\External\Manager($a, $b, $c, $d, $e, $f); | ||
|
|
||
| if ($this->externalManager->acceptShare((int) $id)) { |
There was a problem hiding this comment.
Reza, you just copy one code twice and it is not acceptable. you should just switch between managers per requests like this:
if ($shareType == "group"){
$manager = $this->externalGroupManager;
} else {
$manager = $this->$manager;
}
and then use $manager in the rest of the code.
please refer to core/apps/files_sharing/Controllers/ExternalController.php
There was a problem hiding this comment.
I cannot see the changes in the front part of your pull request. I expected more file changes. can you make sure that all changes are pushed?
There was a problem hiding this comment.
for client-side changes,
those are merged before this PR
but if you have anything more, I'm ready to go forward to code them as well
|
@navid-shokri |
|
@navid-shokri |
2 participants
No description provided.