Skip to content

Another float8 to prevent query-crash #306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Caspervw merged 1 commit into from
Dec 9, 2025
Merged

Another float8 to prevent query-crash #306

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions features/latency2.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,21 @@ Feature: Geo-based latency2 estimates
Given the "signaling" backend is running
And the "testproxy" backend is running

Scenario: latency2 is computed using peer geo persisted on connect
Given "red" is connected as "1u8fw4aph5ypt" with lat,lon as 10,20 and ready for game "323e4567-e89b-12d3-a456-426614174000"
And "yellow" is connected as "h5yzwyizlwao" with lat,lon as 30,40 and ready for game "323e4567-e89b-12d3-a456-426614174000"
And "red,yellow" are joined in a public lobby
And "blue" is connected as "3t3cfgcqup9e" with lat,lon as 50,60 and ready for game "323e4567-e89b-12d3-a456-426614174000"

When "blue" requests lobbies with:
"""json
{}
"""

Then "blue" should have received only these lobbies:
| code | latency2 |
| 19yrzmetd2bn7 | 69 |

Scenario: latency2 is computed from requester to lobby peers
Given these lobbies exist:
| code | game | peers | public |
Expand Down
2 changes: 1 addition & 1 deletion internal/signaling/stores/postgres.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -464,7 +464,7 @@ func (s *PostgresStore) UpdatePeerGeo(ctx context.Context, peerID string, lat, l
UPDATE peers
SET
geo = CASE
WHEN $1 IS NOT NULL AND $2 IS NOT NULL THEN ll_to_earth($1::float8, $2::float8)
WHEN $1::float8 IS NOT NULL AND $2::float8 IS NOT NULL THEN ll_to_earth($1::float8, $2::float8)
ELSE NULL
END,
updated_at = $3
Expand Down