Simplify Android CI with shared action #53
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@marcprux Well, I see you've made my own GitHub Action redundant. I am fine with this action replacing this part of the pipeline and my own action too. No need to maintain two actions that are this similar. FWIW, I ran this particular action on my fork already to try it out and it worked successfully. |
|
Thanks for this! We lost track of it among our other projects. @johankool Just to confirm you suggest merging and using this action instead of the one you contributed? |
|
@stephencelis Yes, fine to merge. Some of your other repos actually already use Marc's action. |
|
@johankool / @stephencelis gentle reminder |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the Android test step of
ci.ymlto use the shared swift-android-action to build and test on Android. In addition to simplifying the workflow, it also speeds it up somewhat because it caches the toolchain, SDK, and Android emulator between runs.