test/system: increase _check_health timeout to fix CI flake - #29374
Open
Mahajan-Sachin wants to merge 1 commit into
Open
test/system: increase _check_health timeout to fix CI flake#29374Mahajan-Sachin wants to merge 1 commit into
Mahajan-Sachin wants to merge 1 commit into
Conversation
Fixes podman-container-tools#29353 Under heavy CI parallelism, systemd timers can delay healthcheck execution ticks beyond 8 seconds, causing _check_health in test/system/220-healthcheck.bats to time out at FailingStreak=2. Increase timeout in _check_health to 15s (25s under CI/parallel load). Signed-off-by: Sachin Mahajan <sachinmahajan903@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ref #29353
Summary
The
_check_healthtest helper intest/system/220-healthcheck.batspreviously used a 5-second timeout (8 seconds when running parallel). Under heavy parallel load on GitHub Actions CI runners, systemd timers for container healthchecks take longer to execute 3 retries, causing false-positive test timeouts whileFailingStreakis at 2.Changes
_check_healthto 15s (25s when running in$CIor parallel$PARALLEL_JOBSLOTjobs).podman eventspolling loop allows sufficient margin for systemd timer execution under CI load without flaking.Checklist
git commit -s)