compat: ignore dead and restarting status filters - #29366
Open
WasThatRudy wants to merge 1 commit into
Open
Conversation
Docker documents `dead` and `restarting` as valid values for the `status` filter on `/containers/json`. Podman returns HTTP 500 when either of them is used even though no Podman container can ever be in those states. Ignore these values in the compat API. If they are the only status filters, return an empty list like Docker does. Invalid status values still return an error. The libpod API still rejects these values since they are Docker specific. Update the libpod API docs to list the states Podman actually supports. Reference: https://docs.docker.com/reference/api/engine/version/v1.51/#tag/Container/operation/ContainerList Fixes: podman-container-tools#28904 Signed-off-by: Rudraksha Singh <rudraksharss@gmail.com>
|
[NON-BLOCKING] Packit jobs failed. @containers/packit-build please check. Everyone else, feel free to ignore. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
docker allows
deadandrestartingas values for thestatusfilter on the compat/containers/jsonendpoint, but podman currently returns HTTP 500 when either of them is used. this changes the compat api to ignore those values and return an empty list if no other status filters are left, which matches docker's behavior.the libpod api still rejects these values since they are docker specific states, as discussed in #28926. the libpod api docs are also updated to list only the states podman supports.
Checklist
Ensure you have completed the following checklist for your pull request to be reviewed:
commits. (
git commit -s). (If needed, usegit commit -s --amend). The author email must matchthe sign-off email address. See CONTRIBUTING.md
for more information.
Fixes: #00000in commit message (if applicable)make validatepr(format/lint checks)Noneif no user-facing changes)Does this PR introduce a user-facing change?