compat: Add DNSNames to GET /containers/{name:.*}/json - #29349
Conversation
Docker Engine API v1.44 introduces a new field named
DNSNames containing all non-fully qualified DNS
names a container takes on a specific network for
the GET /containers/{name:.*}/json endpoint.
Populate DNSNames for the compat endpoints GET /containers/json
and GET /containers/{name:.*}/json.
Add the DNSNames field to GET /libpod/containers/json
(added to entities.ListContainer) too.
Fixes: https://redhat.atlassian.net/browse/RUN-3314
Signed-off-by: Marek Simek <msimek@redhat.com>
edeab29 to
e4468b1
Compare
Oh, I'll fix this. |
|
I have not really looked at the details here but I already reviewed #29227 from @ashley-cui. Can you cross check that, which version is needed? |
Oh, thank you. I knew that v1.45 mentions:
but unfortunately completely missed that Ashley did this one too:( Well, at least I've learnt a bit about networking. I implemented it a bit differently and Ashley's version has much better tests. I'll comment there. |
|
Closing in favor of #29227 |
Docker Engine API v1.44 introduces a new field named
DNSNamescontaining all non-fully qualified DNS names a container takes on a specific network for theGET /containers/{name:.*}/jsonendpoint.DNSNamesfor the compat endpointsGET /containers/jsonandGET /containers/{name:.*}/json(the Docker changelog mentions only/containers/{name:.*}/json, but it's the same moby structure).DNSNamesfield to GET /libpod/containers/json (added to entities.ListContainer) too based on RUN-3314 description - works withpodman list/ps --format '{{.DNSNames}}'Fixes: https://redhat.atlassian.net/browse/RUN-3314
Checklist
Ensure you have completed the following checklist for your pull request to be reviewed:
commits. (
git commit -s). (If needed, usegit commit -s --amend). The author email must matchthe sign-off email address. See CONTRIBUTING.md
for more information.
Fixes: #00000in commit message (if applicable)make validatepr(format/lint checks)Noneif no user-facing changes)Does this PR introduce a user-facing change?
Example output