Add versioned Libpod API paths to generated Swagger - #29331
Open
JJordan0C wants to merge 1 commit into
Open
Conversation
Update the generated Swagger specification so that Libpod API paths include the required version prefix. Keep the unversioned ping endpoint unchanged, reuse the version path parameter, and add tests for the path rewriting logic. Fixes: podman-container-tools#15376 Signed-off-by: JJordan0K <69581081+JJordan0C@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
I came across #15376 and noticed it had been open for quite some time, so I decided to take a look.
This PR updates the generated Swagger specification so that Libpod API paths include the required version prefix.
Specifically, it:
/libpod/...to/v{version}/libpod/...;/libpod/_pingunversioned;versionpath parameter;This only affects Swagger generation and does not change the Podman daemon or API routing.
I hope this approach fits the project and helps address the issue. I’d appreciate any feedback or suggestions.
Fixes: #15376
Checklist
commits. (
git commit -s). (If needed, usegit commit -s --amend). The author email must matchthe sign-off email address. See CONTRIBUTING.md
for more information.
Fixes: #15376in commit messagemake validateprDoes this PR introduce a user-facing change?