Fix a few format-specifier warnings - #7012
Open
nalind wants to merge 2 commits into
Open
Conversation
|
Ephemeral COPR build failed. @containers/packit-build please check. |
Luap99
approved these changes
Jul 30, 2026
Luap99
left a comment
Luap99
left a comment
Member
There was a problem hiding this comment.
There is a linter for this but I guess %q is technically valid and thus not flagged?
LGTM
In a few places, we were using %q as a format specifier for numbers, and for enumerated types which didn't have a String() method. Signed-off-by: Nalin Dahyabhai <nalin@redhat.com>
…t rw Bind mount a directory read-write if we're going to try relabeling its contents. Signed-off-by: Nalin Dahyabhai <nalin@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
In a few places, we were using "%q" as a format specifier for numbers, and for enumerated types which didn't have a
String()method.How to verify it
Updated unit test!
Which issue(s) this PR fixes:
None
Special notes for your reviewer:
Does this PR introduce a user-facing change?