Skip to content

images: fix stale header comments and drop unset $SUDO - #41

Open
ROKUMATE wants to merge 1 commit into
podman-container-tools:mainfrom
ROKUMATE:images-stale-leftovers
Open

images: fix stale header comments and drop unset $SUDO#41
ROKUMATE wants to merge 1 commit into
podman-container-tools:mainfrom
ROKUMATE:images-stale-leftovers

Conversation

@ROKUMATE

Copy link
Copy Markdown
Contributor

Leftovers from the containers/automation_images import:

  • get_fedora_url.sh:3 — "called by the Makefile". No Makefile in this repo; build.sh:72-73
    calls it.
  • fedora_packaging.sh:3-6, debian_packaging.sh:3-6 — "called from fedora_setup.sh and
    various Dockerfiles… assumes lib.sh has been sourced". None of those exist. Real callers are
    build.sh via virt-customize and container-images/podman_cidev/Containerfile.
  • fedora_packaging.sh:216 — pipes to $SUDO tee, but SUDO came from lib.sh and is set
    nowhere here, so it expands to empty. debian_packaging.sh uses a bare tee in the same place.
  • fedora_packaging.sh:23# shellcheck disable=SC2154 no longer suppresses anything.

Signed-off-by: ROKUMATE <rohitkumawat0110@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant