renovate: fix CI VM Image file pattern - #37
Merged
Luap99 merged 1 commit intoAug 10, 2026
Conversation
2ad2611 replaced this broken regex with a glob in the custom manager but the same pattern stayed in the CI VM Image packageRule, so the rule never matches. Image update PRs get the plain title instead of the group name, no reviewers assigned, and maxMajorIncrement stays at the 500 default instead of 0. Same glob as the manager uses now. Signed-off-by: Tushar Verma <tusharmyself06@gmail.com>
Member
|
@vtushar06 Can you turn of your copilot review setting? It is annoying if that spams the same useless comment on each PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed the AUTOMATION_RELEASE update PRs across the repos come in with the plain renovate title and no reviewers, so I went looking at why the CI VM Image rule was not doing that.
The packageRule still has the regex that 2ad2611 replaced in the custom manager -
/^.github/workflows/*.yml$/without the.*, so it matches no real workflow filename and the whole rule is inert. That also meansmaxMajorIncrement: 0never applies, so image updates would stop being proposed at a year rollover once the date-version jump exceeds the 500 default.Recent examples where the rule should have fired but the PRs have the plain title and no requested reviewers: skopeo#2929, container-libs#1008, podman#29253.
Same glob the manager uses since 2ad2611.