images: stop zstd compressing the image twice - #35
Merged
Conversation
Signed-off-by: Tushar Verma <tusharmyself06@gmail.com>
Contributor
Author
|
@Luap99 this is first time in this repo, let me know if the fix should just drop the second argument instead. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed zstd takes both of those as input files rather than input and output, so it compresses the image and then compresses the resulting .zst again.
On a 300MB test that was 233s instead of 142s and left an extra 48MB .zst.zst behind. Nothing picks that file up so it is only runner time and disk.