48116 frontend [ templates ] localize empty checklist validation errors#269
Open
aicarma-artyom-maslov wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Low Risk
Localized error mapping only in
getErrorMessageand locale files; no auth or data-path changes.Overview
Template save/API validation errors for checklists now resolve to localized message keys instead of raw English backend strings.
getErrorMessagegainsmapValidationMessage: blank-value errors (value: this field may not be blank.) map tovalidation.checklist-item-emptywhendetails.api_namestarts withcitem-, otherwisevalidation.field-empty. The backend message Checklist items not exists or invalid. maps tovalidation.checklist-items-invalid.ICustomError.detailsnow includes optionalapi_namefor that branching.New copy was added in en_US and ru_RU for those keys, with unit tests covering the three mapping cases.
Reviewed by Cursor Bugbot for commit 911d198. Bugbot is set up for automated code reviews on this repo. Configure here.
Note
Localize empty checklist validation errors in frontend templates
validation.checklist-item-emptyandvalidation.checklist-items-invalid) to the en_US.ts and ru_RU.ts locale files.getErrorMessagein getErrorMessage.ts with amapValidationMessagehelper that detects blank-value errors and returnsvalidation.checklist-item-emptywhendetails.api_namestarts withcitem-, orvalidation.field-emptyotherwise.'Checklist items not exists or invalid.'tovalidation.checklist-items-invalidin the error mapper.Macroscope summarized 911d198.