⚙️ 45773 backend [ templates ] Add FieldSets

[pneumojoseph]

Note

Medium Risk
Touches core template/workflow field creation, task completion validation, and DB schema migrations; incorrect fieldset or rule handling could break form saves or block task completion.

Overview
Adds reusable fieldsets so kickoff and task template forms can group fields with layout metadata and validation rules, wired through template editing into running workflows.

New template models FieldsetTemplate / FieldsetTemplateRule and runtime FieldSet / FieldSetRule (migration 0255_add_fieldsets) support shared definitions (is_shared, shared_fieldset copies), attachment to kickoff or task templates, and fields linked via fieldset FK plus M2M rules. sum_equal rules require number fields whose values sum to a configured target; workflow kickoff updates and task completion now validate those rules (including OR when multiple rules share a type).

Template and workflow APIs gain fieldsets on kickoff/task serializers, FieldsetMixin for create/update from shared fieldset IDs, and FieldSetTemplateService / FieldSetService for instantiation. Output-field resolution on Template and Workflow now includes fields nested under fieldsets, not only direct task/kickoff fields.

Supporting changes: RelatedApiNameField / RelatedApiNameListField for account+template-scoped api_name resolution, extracted FieldTemplateService, default delete() on BaseModelService, and template “fields only” read serializers moved to template_fields.py. SystemVariable.TASK_VARS is aligned with workflow name variables for task naming.

^{Reviewed by Cursor Bugbot for commit 07df431. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Add FieldSet support to templates, tasks, and kickoffs with file service integration

• Introduces FieldsetTemplate, FieldSet, and related rule models to group fields under templates, tasks, and kickoffs; existing querysets, serializers, versioning services, and workflow action services are updated to create, update, and validate fieldsets and their rules.
• Replaces legacy Google Cloud Storage file handling with a new file service (src.storage): a FastAPI microservice backed by SeaweedFS/S3, with FileServiceAuthMiddleware, AttachmentService, guardian object permissions, and management commands for migrating existing attachments.
• Comment and field attachment submission no longer accepts attachments in API payloads; attachments are now derived by parsing markdown in text content and synced via refresh_attachments/sync_storage_attachments_for_scope.
• Frontend RichText component is rewritten to use a markdown-it pipeline with sanitized HTML, line clamping via maxLines, and support for interactive checklists, embedded video, and image placeholders.
• uploadFiles now uploads to the file service (batched in groups of 3), returns string IDs and markdown links, and no longer requires accountId or Google Cloud signed URLs.
• Nginx configs gain a file-service upstream, /files/ proxy location, default server blocks returning 444 for unknown hosts, and a Railway-specific dynamic config with envsubst entrypoint.
• Risk: /workflows/attachments and /workflows/public/attachments endpoints are removed and will return 404; FieldMixin no longer inherits AccountBaseMixin, affecting any model that depended on that behavior.

^{Macroscope summarized 0e1408e.}

[macroscopeapp]

Macroscope has since reviewed this pull request. An earlier review was skipped by a cost limit; a review has now completed, so that notice no longer applies.

[cursor]

Photo sync omits new file values

Medium Severity

apply_photo_to_user calls sync_account_file_fields with new_values=[] after setting user.photo. That only removes the old attachment and never registers the new photo URL through the sync path used everywhere else for account file fields.

 

^{Reviewed by Cursor Bugbot for commit 0e1408e. Configure here.}

[macroscopeapp]

🟠 High templates/mixins.py:271

create_or_update_fieldsets raises KeyError when updating an existing fieldset whose payload omits title or description. Both fields are optional/blankable, so a valid request that references an existing api_name without those keys returns a 500 instead of preserving the current values. The update_kwargs comparisons index fieldset_data['title'] and fieldset_data['description'] unconditionally, but those keys may be absent — the later partial_update_instance call already uses .get() correctly. Use .get() in the comparison checks as well.

Suggested change

	if fieldset.order != fieldset_data['order']:
	update_kwargs['order'] = fieldset_data['order']
	if fieldset.title != fieldset_data['title']:
	update_kwargs['title'] = fieldset_data['title']
	if fieldset.description != fieldset_data['description']:
	update_kwargs['description'] = fieldset_data['description']
	if fieldset.order != fieldset_data['order']:
	update_kwargs['order'] = fieldset_data['order']
	if fieldset.title != fieldset_data.get('title'):
	update_kwargs['title'] = fieldset_data.get('title')
	if fieldset.description != fieldset_data.get('description'):
	update_kwargs['description'] = fieldset_data.get('description')

🚀 Reply "fix it for me" or copy this AI Prompt for your agent:

In file @backend/src/processes/serializers/templates/mixins.py around lines 271-276:

`create_or_update_fieldsets` raises `KeyError` when updating an existing fieldset whose payload omits `title` or `description`. Both fields are optional/blankable, so a valid request that references an existing `api_name` without those keys returns a 500 instead of preserving the current values. The `update_kwargs` comparisons index `fieldset_data['title']` and `fieldset_data['description']` unconditionally, but those keys may be absent — the later `partial_update_instance` call already uses `.get()` correctly. Use `.get()` in the comparison checks as well.

[macroscopeapp]

🟡 Medium tasks/task_version.py:257

_update_fieldsets never copies fieldset_data['title'] into the FieldSet defaults, so newly added fieldsets lose their configured title and title edits in a new template version are not propagated to running workflows — task forms display an empty or stale heading. Consider adding 'title': fieldset_data['title'] to the defaults dict.

Suggested change

	api_name=fieldset_data['api_name'],
	defaults={
	'account_id': self.instance.account_id,
	'name': fieldset_data['name'],
	'account_id': self.instance.account_id,
	'name': fieldset_data['name'],
	'title': fieldset_data['title'],
	'description': fieldset_data['description'],

🚀 Reply "fix it for me" or copy this AI Prompt for your agent:

In file @backend/src/processes/services/tasks/task_version.py around lines 257-260:

`_update_fieldsets` never copies `fieldset_data['title']` into the `FieldSet` `defaults`, so newly added fieldsets lose their configured title and title edits in a new template version are not propagated to running workflows — task forms display an empty or stale heading. Consider adding `'title': fieldset_data['title']` to the `defaults` dict.

[macroscopeapp]

🟠 High tasks/task_version.py:179

When a template update moves an existing field into, out of, or between fieldsets, _update_field creates a new TaskField with an empty value and the cleanup deletes the old row, silently discarding the field's existing workflow value and selections. The fieldset foreign key is included in the update_or_create lookup, so moving the field changes the lookup identity and triggers a create-then-delete instead of an update. Move fieldset out of the lookup and into defaults so the existing row is updated in place.

🚀 Reply "fix it for me" or copy this AI Prompt for your agent:

In file @backend/src/processes/services/tasks/task_version.py around line 179:

When a template update moves an existing field into, out of, or between fieldsets, `_update_field` creates a new `TaskField` with an empty `value` and the cleanup deletes the old row, silently discarding the field's existing workflow value and selections. The `fieldset` foreign key is included in the `update_or_create` lookup, so moving the field changes the lookup identity and triggers a create-then-delete instead of an update. Move `fieldset` out of the lookup and into `defaults` so the existing row is updated in place.

[cursor]

Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.

There are 2 total unresolved issues (including 1 from previous review).

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.}

^{Reviewed by Cursor Bugbot for commit 07df431. Configure here.}

[cursor]

Fieldset title dropped on version sync

Medium Severity

_update_fieldsets omits title from update_or_create defaults even though version schemas include it. When a template version updates a running workflow, fieldset titles stay blank or stale while name, description, layout, and other attributes sync correctly.

Additional Locations (1)

• backend/src/processes/services/workflows/kickoff_version.py#L139-L151

 

^{Reviewed by Cursor Bugbot for commit 07df431. Configure here.}