-
-
Notifications
You must be signed in to change notification settings - Fork 279
changed deepClone back to original and added deepProxy #1169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
commit: |
Size Change: +671 B (+4.88%) 🔍 Total Size: 14.4 kB
ℹ️ View Unchanged
|
I still need to do the documentation and it could use a few more tests. Wanted to push the code up first to get feedback first. |
Thanks. This feels more comfortable and I think we could deprecate deepClone in the near future. |
I added tests and updated some docs for new exports from proxyMap/proxySet. Only thing left really is adding documentation for deepProxy. I'm wondering if we should add it as it's own small page within utils like proxyMap and proxySet have. I think it depends on if this is something we're going to want to keep around or if we eventually would like to deprecate it like we will with deepClone. @dai-shi thoughts? |
I think it's something to keep around, but I'm not very sure. |
Added page for unstable_deepProxy to the docs and updated a few other places. I think this should be good to go. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Related Bug Reports or Discussions
#1165
Fixes #1165
Reverts #1074
Summary
Added deepProxy function and reverted deepClone back to original form. Split the tests for deepProxy and deepClone into different test files.
Check List
pnpm run fix
for formatting and linting code and docs