call setsid() in ProxyCommand subprocess - #73
Open
ploxiln wants to merge 1 commit into
Open
Conversation
Owner
Author
|
I think this will need to be avoided on windows where setsid() is not available. |
so that signals sent to the foreground process group are not also received by the ProxyCommand (it should be closed by the transport when the parent shuts down) inspired by paramiko#1183
ploxiln
force-pushed
the
proxycommand_setsid
branch
from
November 27, 2021 07:10
3ca27dd to
bceba1b
Compare
Owner
Author
|
I'm now thinking that maybe this should be optional anyway, maybe not all ProxyCommands should use
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
so that signals sent to the foreground process group
are not also received by the ProxyCommand
(it should be closed by the transport when the parent shuts down)
inspired by paramiko#1183