Skip to content

call setsid() in ProxyCommand subprocess - #73

Open
ploxiln wants to merge 1 commit into
masterfrom
proxycommand_setsid
Open

call setsid() in ProxyCommand subprocess#73
ploxiln wants to merge 1 commit into
masterfrom
proxycommand_setsid

Conversation

@ploxiln

@ploxiln ploxiln commented Mar 28, 2020

Copy link
Copy Markdown
Owner

so that signals sent to the foreground process group
are not also received by the ProxyCommand
(it should be closed by the transport when the parent shuts down)

inspired by paramiko#1183

@ploxiln

ploxiln commented Jul 21, 2020

Copy link
Copy Markdown
Owner Author

I think this will need to be avoided on windows where setsid() is not available.

so that signals sent to the foreground process group
are not also received by the ProxyCommand
(it should be closed by the transport when the parent shuts down)

inspired by paramiko#1183
@ploxiln
ploxiln force-pushed the proxycommand_setsid branch from 3ca27dd to bceba1b Compare November 27, 2021 07:10
@ploxiln

ploxiln commented Nov 27, 2021

Copy link
Copy Markdown
Owner Author

I'm now thinking that maybe this should be optional anyway, maybe not all ProxyCommands should use setsid(). Also, since Python-3.2:

if start_new_session is true the setsid() system call will be made in the child process prior to the execution of the subprocess. (POSIX only)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant