add support for rsa-sha2 signatures - #149
Draft
ploxiln wants to merge 2 commits into
Draft
Conversation
Existing ssh-rsa keys can be used with sha2-256 or sha2-512 signatures instead of traditional sha1: RFC-8332 Add support for extention negotiation to discover support for the new rsa signature types: MSG_EXT_INFO / server-sig-algs: RFC-8308 Ported from upstream Paramiko to Paramiko-NG and trimmed: Co-Authored-By: Pierce Lopez <pierce.lopez@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support for rsa-sha2-256 and rsa-sha2-512, as well as the ext-info / server-sig-algs in handshake, used to advertise support for these new signature types.
I don't want to just copy exactly how it was handled in upstream paramiko, because if it doesn't get the ext-info message it assumes the new signature types for rsa keys are supported, rather than the inverse.
I've stalled out some months ago, because I've run into some buggyness ... and this is actually pretty tricky and messy to implement in this codebase, and my motivation ran out 🤷
References I'm working from: