Skip to content

Fix issue where visible property of one legend was affecting another #7574

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix issue where visible property of one legend was affecting another #7574

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e1b7264
fix legend.visible logic which was affecting other legends
emilykl Oct 7, 2025
0de2980
add jasmine test
emilykl Oct 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 9 additions & 10 deletions src/components/legend/defaults.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,9 +33,11 @@ function groupDefaults(legendId, layoutIn, layoutOut, fullData) {
};

var globalFont = layoutOut.font || {};
var grouptitlefont = Lib.coerceFont(coerce, 'grouptitlefont', globalFont, { overrideDflt: {
size: Math.round(globalFont.size * 1.1)
}});
var grouptitlefont = Lib.coerceFont(coerce, 'grouptitlefont', globalFont, {
overrideDflt: {
size: Math.round(globalFont.size * 1.1)
}
});

var legendTraceCount = 0;
var legendReallyHasATrace = false;
Expand Down Expand Up @@ -82,13 +84,13 @@ function groupDefaults(legendId, layoutIn, layoutOut, fullData) {
}

if((!isShape && Registry.traceIs(trace, 'bar') && layoutOut.barmode === 'stack') ||
['tonextx', 'tonexty'].indexOf(trace.fill) !== -1) {
defaultOrder = helpers.isGrouped({traceorder: defaultOrder}) ?
['tonextx', 'tonexty'].indexOf(trace.fill) !== -1) {
defaultOrder = helpers.isGrouped({ traceorder: defaultOrder }) ?
'grouped+reversed' : 'reversed';
}

if(trace.legendgroup !== undefined && trace.legendgroup !== '') {
defaultOrder = helpers.isReversed({traceorder: defaultOrder}) ?
defaultOrder = helpers.isReversed({ traceorder: defaultOrder }) ?
'reversed+grouped' : 'grouped';
}
}
Expand Down Expand Up @@ -237,10 +239,7 @@ module.exports = function legendDefaults(layoutIn, layoutOut, fullData) {

groupDefaults(legendId, layoutIn, layoutOut, allLegendsData);

if(
layoutOut[legendId] &&
layoutOut[legendId].visible
) {
if(layoutOut[legendId]) {
layoutOut[legendId]._id = legendId;
}

Expand Down
Loading