-
-
Notifications
You must be signed in to change notification settings - Fork 788
Add underline to formtabs items for proper link identification #7419
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
@sneridagh I'm having problems with this paths inside readme.md, lychee is unable of solve the #gh-light-mode-only, can you help me?
|
I got you. Done in b08b7e5. Strange, I thought I had previously done these on |
@stevepiercy The problem is that the README in packages/volto gets overwritten with a copy of the top-level README during a release: https://github.com/plone/volto/blob/main/packages/volto/.release-it.json#L10 |
@davisagli so what's the solution? I'd prefer to tweak the relative paths to the logos during the release, if possible. I could configure the link checker not to check this file since it's already checked the original file at the root, but then we'll always have a bad image |
@stevepiercy Someone can modify the command that copies the file to also do a replacement on its contents. This isn't a priority for me personally. |
a11y
Add underline to links in content type's - menu formtabs
Links in content types with multiple tabs now have proper visual identification with an underline.
The change was applied directly in Volto’s CSS, as the Semantic UI component does not allow direct customization for that.
Important: Cherry-pick required for V18 and V17