Skip to content

Conversation

Wagner3UB
Copy link
Contributor

@Wagner3UB Wagner3UB commented Sep 29, 2025

a11y
Add underline to links in content type's - menu formtabs

Links in content types with multiple tabs now have proper visual identification with an underline.
The change was applied directly in Volto’s CSS, as the Semantic UI component does not allow direct customization for that.

Important: Cherry-pick required for V18 and V17

Screenshot 2025-09-29 at 14 36 15

@Wagner3UB Wagner3UB self-assigned this Sep 29, 2025
@Wagner3UB Wagner3UB added the 99 tag: UX Accessibility Accessibility issues label Sep 29, 2025
@Wagner3UB
Copy link
Contributor Author

Wagner3UB commented Oct 1, 2025

@sneridagh I'm having problems with this paths inside readme.md, lychee is unable of solve the #gh-light-mode-only, can you help me?

<img align="right" width="300" alt="Volto logo png" src="./logos/VoltoLogoEra2.png#gh-light-mode-only" />
<img align="right" width="300" alt="Volto logo png" src="./logos/VoltoLogoEra2-dark-mode.png#gh-dark-mode-only" />

@stevepiercy
Copy link
Collaborator

@sneridagh I'm having problems with this paths inside readme.md, lychee is unable of solve the #gh-light-mode-only, can you help me?

I got you. Done in b08b7e5.

Strange, I thought I had previously done these on main.

@davisagli
Copy link
Member

@stevepiercy The problem is that the README in packages/volto gets overwritten with a copy of the top-level README during a release: https://github.com/plone/volto/blob/main/packages/volto/.release-it.json#L10

@stevepiercy
Copy link
Collaborator

@davisagli so what's the solution?

I'd prefer to tweak the relative paths to the logos during the release, if possible.

I could configure the link checker not to check this file since it's already checked the original file at the root, but then we'll always have a bad image src link in the copy.

@davisagli
Copy link
Member

@stevepiercy Someone can modify the command that copies the file to also do a replacement on its contents. This isn't a priority for me personally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
99 tag: UX Accessibility Accessibility issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants