main: allow other sources in Video block #7318
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…es. Added allowedPeertubeInstances to the video block config to add others url condition at Video Body component for peertube instances update Video Block component test snapshot improve Edit view to give more information about block possibilities changelog rollback video block edit msgid modification i18n update snapshots update test snapshots modify youtube url regex to make it more strict feat: add more unit tests for video block component improve Array testing for peertubeInstances better matching for peertube embed update video block snapshot add cypress test for peertube instance video block news feature video block peertube instances docs video block test snapshot tested with vitest improve video block docs video block docs fix docs docs videoBlock docs hide Peertube from allowed origins if there is no peertube instance in the config list add Peertube info to the docs get the peertube instances config list empty
9 tasks
wesleybl
requested changes
Sep 7, 2025
| restricted: false, | ||
| mostUsed: true, | ||
| sidebarTab: 1, | ||
| allowedPeertubeInstances: [], |
There was a problem hiding this comment.
On Volto 19 we can have the list filled.
| restricted: false, | ||
| mostUsed: true, | ||
| sidebarTab: 1, | ||
| allowedPeertubeInstances: [], |
There was a problem hiding this comment.
Even with the list empty I can insert videos from Peertube.
| <Embed {...embedSettings} /> | ||
| </> | ||
| ) : Object.keys(iframeSettings).length > 0 ? ( | ||
| <iframe title="Peertube video iframe" {...iframeSettings}></iframe> |
There was a problem hiding this comment.
When the block has the Peertube video and I go to editing, when I click on the video, it does not load the video block settings in the menu on the right.
|
@ionlizarazu Can you take a look here please? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Forward-port of #6870 to main
📚 Documentation preview 📚: https://volto--7318.org.readthedocs.build/