Skip to content

Added Filtering by _createdAt, and _updatedAt to CMS API Filter Query #138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 12 commits into
base: master
Choose a base branch
from
Open

Added Filtering by _createdAt, and _updatedAt to CMS API Filter Query #138

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
d007f26
_createdAt, _updatedAt filter added
hyunnbunt Apr 27, 2025
08a7bde
removed log and changed a variable name
hyunnbunt Apr 28, 2025
9cfd712
removed column variable
hyunnbunt Apr 28, 2025
70a609b
Date -> Datetime
hyunnbunt Apr 28, 2025
f3d242c
Two if condition combined
hyunnbunt Apr 28, 2025
a152d96
Add _createdAt, _updatedAt filter
hyunnbunt Aug 4, 2025
4e2401e
Removed log
hyunnbunt Aug 4, 2025
400d86e
Rebased, moved code from buildFilterClause -> makeTypedFieldSql
hyunnbunt Aug 5, 2025
e9c94d1
Separate _id field from _createdAt and _updatedAt, Add test for gener…
hyunnbunt Aug 5, 2025
fc59e60
Removed unrelated codes
hyunnbunt Aug 5, 2025
d2492b8
Refactor: Remove double quote
hyunnbunt Aug 5, 2025
6e1ac12
Change test codes
hyunnbunt Aug 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 34 additions & 0 deletions platform/wab/src/wab/server/util/cms-util.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -227,6 +227,40 @@ describe("makeSqlCondition", () => {
});
});

it("special cases _createdAt field", () => {
expect(
makeSqlCondition(
TEST_TABLE,
{
_createdAt: "2025-01-01T00:00:00Z",
},
{ useDraft: false }
)
).toEqual({
condition: `r.createdAt = :val0`,
params: {
val0: "2025-01-01T00:00:00Z",
},
});
});

it("special cases _updatedAt field", () => {
expect(
makeSqlCondition(
TEST_TABLE,
{
_updatedAt: "2025-01-01T00:00:00Z",
},
{ useDraft: false }
)
).toEqual({
condition: `r.updatedAt = :val0`,
params: {
val0: "2025-01-01T00:00:00Z",
},
});
});

it("accesses nested nested field", () => {
expect(
makeSqlCondition(
Expand Down
5 changes: 3 additions & 2 deletions platform/wab/src/wab/server/util/cms-util.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -199,8 +199,9 @@ export const makeTypedFieldSql = (
opts: { useDraft?: boolean }
) => {
const dataRef = makeDataRef(opts);
if (field === "_id") {
return "r.id";

if (field === "_id" || field === "_createdAt" || field === "_updatedAt") {
return `r.${field.replace("_", "")}`;
}

// Simple field access
Expand Down
Loading