export metrics to track shared preload libraries in postgres #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
exports one new metric,
`pg_shared_preload_libraries_library_enabled{library=<name}=1` per
library across the fleet
This helps us understand and track rollouts
JTCunning
reviewed
Sep 24, 2025
| "github.com/prometheus/client_golang/prometheus" | ||
| ) | ||
|
|
||
| const sharedPreloadLibrariesSubsystem = "shared_preload_libraries" |
There was a problem hiding this comment.
Suggested change
| const sharedPreloadLibrariesSubsystem = "shared_preload_libraries" | |
| const sharedPreloadLibrariesSubsystem = "settings_shared_preload_libraries" |
If we're only ever going to emit a metric from querying pg_settings I think it's worth either applying that namespace in the metric constant, or in the namespace that's getting passed below, which I'm not sure where that comes from. Follow your heart.
There was a problem hiding this comment.
gonna slightly adjust but yeah, agree.
maxenglander
approved these changes
Sep 25, 2025
| @@ -0,0 +1,87 @@ | |||
| // Copyright 2024 The Prometheus Authors | |||
| @@ -0,0 +1,187 @@ | |||
| // Copyright 2024 The Prometheus Authors | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
exports one new metric,
pg_shared_preload_libraries_library_enabled{library=<name}=1perlibrary across the fleet
This helps us understand and track rollouts