Skip to content

fix: propagate latest cursor errors#79

Merged
nickvanw merged 1 commit into
mainfrom
fix/latest-cursor-errors
Jun 16, 2026
Merged

fix: propagate latest cursor errors#79
nickvanw merged 1 commit into
mainfrom
fix/latest-cursor-errors

Conversation

@nickvanw

Copy link
Copy Markdown
Contributor

Summary

  • wrap and return the actual latest-cursor lookup error from Read
  • return client.Sync errors from getLatestCursorPosition instead of converting them to nil
  • add regression coverage that latest-cursor Sync and Recv failures stop before the data sync path

Testing

  • GOCACHE=/tmp/fivetran-go-build go test ./lib (fails before tests run: link: vitess.io/vitess/go/hack: invalid reference to runtime.roundupsize)

@nickvanw nickvanw force-pushed the fix/latest-cursor-errors branch from 61b605f to 0c228e1 Compare June 15, 2026 19:03
@nickvanw nickvanw force-pushed the fix/latest-cursor-errors branch from 0c228e1 to 5b21269 Compare June 16, 2026 15:25
@nickvanw nickvanw merged commit 5a0e2a1 into main Jun 16, 2026
20 of 22 checks passed
@nickvanw nickvanw deleted the fix/latest-cursor-errors branch June 16, 2026 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants