Open
Conversation
ademuanthony
force-pushed
the
account-test
branch
from
ba99cc9 to
809c208
Compare
ademuanthony
force-pushed
the
account-test
branch
from
809c208 to
7ee85eb
Compare
oluwandabira
suggested changes
Mar 16, 2020
Contributor
oluwandabira
left a comment
oluwandabira
left a comment
There was a problem hiding this comment.
The Describe's don't need to have the full method signature, we can't overload methods in go so just the name would suffice.
Contributor
oluwandabira
left a comment
oluwandabira
left a comment
There was a problem hiding this comment.
git ignore the test rootDir
itswisdomagain
suggested changes
Apr 26, 2020
- add github workflows for tests
- change windows_test.dockerfile base image to nanoserver
ademuanthony
force-pushed
the
account-test
branch
from
4698a28 to
fbda18b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR add tests for account operations in the accounts.go file.
The PR use github.com/onsi/ginkgo and github.com/onsi/gomega as introduced by @RogueElement in his on going PR #96.