Skip to content

pkp/pkp-lib#11583 strict mode update and removed PKP_STRICT_MODE const #2186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
touhidurabir wants to merge 2 commits into
base: main
Choose a base branch
from
+25 −51
Open

pkp/pkp-lib#11583 strict mode update and removed PKP_STRICT_MODE const #2186

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ce7f96c
pkp/pkp-lib#11583 Removed PKP_STRICT_MODE
touhidurabir Dec 4, 2025
b521fc3
pkp/pkp-lib#11583 Submodule Update ##touhidurabir/i11583_main##
touhidurabir Dec 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions classes/author/Author.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,8 +36,3 @@ public function getIsEditor(): bool
);
}
}

if (!PKP_STRICT_MODE) {
// Required for import/export toolset
class_alias('\APP\author\Author', '\Author');
}
14 changes: 4 additions & 10 deletions classes/core/Application.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,21 +43,15 @@ class Application extends PKPApplication
public function __construct()
{
parent::__construct();
if (!PKP_STRICT_MODE) {
foreach ([

if (!app()->getApplicationStrictModeStatus()) {
app()->registerGlobalConstants(static::class, [
'ASSOC_TYPE_MONOGRAPH',
'ASSOC_TYPE_PUBLICATION_FORMAT',
'ASSOC_TYPE_PRESS',
'ASSOC_TYPE_SERIES',
'ASSOC_TYPE_CHAPTER',
] as $constantName) {
if (!defined($constantName)) {
define($constantName, constant('self::' . $constantName));
}
}
if (!class_exists('\Application')) {
class_alias('\APP\core\Application', '\Application');
}
]);
}

// Add application locales
Expand Down
4 changes: 0 additions & 4 deletions classes/publication/Publication.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,3 @@ public function getLocalizedCoverImageThumbnailUrl(int $contextId)
]);
}
}

if (!PKP_STRICT_MODE) {
class_alias('\APP\publication\Publication', '\Publication');
}
4 changes: 0 additions & 4 deletions classes/publicationFormat/PublicationFormat.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -664,7 +664,3 @@ public function setStoredPubId($pubIdType, $pubId)
}
}
}

if (!PKP_STRICT_MODE) {
class_alias('\APP\publicationFormat\PublicationFormat', '\PublicationFormat');
}
4 changes: 0 additions & 4 deletions classes/submission/Submission.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,3 @@ public function setEnableChapterPublicationDates($enableChapterPublicationDates)
$this->setData('enableChapterPublicationDates', $enableChapterPublicationDates);
}
}

if (!PKP_STRICT_MODE) {
class_alias('\APP\submission\Submission', '\Submission');
}
1 change: 1 addition & 0 deletions dbscripts/xml/upgrade.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -196,6 +196,7 @@
<migration class="PKP\migration\upgrade\v3_6_0\I11913_AssociatePublicationsWithReviewRounds"/>
<migration class="APP\migration\upgrade\v3_6_0\I857_ContributorRolesTypes"/>
<migration class="PKP\migration\upgrade\v3_6_0\I12046_AssignMachineReadableRecommendationType"/>
<migration class="PKP\migration\upgrade\v3_6_0\I11583_ClassNamespaceFromDotNotationClassPath"/>
<code function="rebuildSearchIndex" />
<note file="docs/release-notes/README-3.6.0" />
</upgrade>
Expand Down
2 changes: 1 addition & 1 deletion lib/pkp
Open in desktop
Submodule pkp updated 41 files
+0 −4 classes/citation/Citation.php
+0 −4 classes/citation/filter/CitationListTokenizerFilter.php
+0 −1 classes/core/DataObject.php
+21 −26 classes/core/PKPApplication.php
+0 −3 classes/core/PKPComponentRouter.php
+53 −0 classes/core/PKPContainer.php
+11 −0 classes/core/ValidationServiceProvider.php
+1 −5 classes/filter/ClassTypeDescription.php
+2 −1 classes/filter/CompositeFilter.php
+4 −3 classes/filter/Filter.php
+4 −9 classes/filter/FilterDAO.php
+0 −4 classes/filter/FilterGroup.php
+0 −4 classes/filter/PrimitiveTypeDescription.php
+0 −4 classes/filter/TypeDescription.php
+11 −13 classes/filter/TypeDescriptionFactory.php
+0 −4 classes/galley/Galley.php
+11 −5 classes/i18n/Locale.php
+3 −12 classes/install/Installer.php
+1 −1 classes/install/PKPInstall.php
+6 −6 classes/metadata/MetadataDataObjectAdapter.php
+3 −8 classes/metadata/MetadataDescription.php
+6 −5 classes/metadata/MetadataTypeDescription.php
+104 −0 classes/migration/upgrade/v3_6_0/I11583_ClassNamespaceFromDotNotationClassPath.php
+20 −27 classes/plugins/PluginRegistry.php
+2 −2 classes/submission/maps/Schema.php
+0 −4 classes/submissionFile/SubmissionFile.php
+0 −4 classes/validation/ValidatorTypeDescription.php
+0 −4 classes/xslt/XMLTypeDescription.php
+1 −1 controllers/grid/queries/form/QueryForm.php
+0 −120 includes/functions.php
+99 −0 tests/classes/core/StrictModeTest.php
+2 −1 tests/classes/filter/ClassTypeDescriptionTest.php
+2 −1 tests/classes/filter/FilterDAOTest.php
+9 −6 tests/classes/filter/FilterTest.php
+8 −5 tests/classes/filter/PersistableFilterTest.php
+0 −4 tests/classes/filter/TestClass1.php
+0 −4 tests/classes/filter/TestClass2.php
+7 −3 tests/classes/filter/TypeDescriptionFactoryTest.php
+2 −1 tests/classes/metadata/MetadataDescriptionTest.php
+1 −5 tests/classes/metadata/TestSchema.php
+4 −0 tests/phpunit-bootstrap.php
2 changes: 1 addition & 1 deletion plugins/generic/customBlockManager
Open in desktop
Submodule customBlockManager updated 2 files
+0 −4 CustomBlockManagerPlugin.php
+0 −4 CustomBlockPlugin.php
2 changes: 1 addition & 1 deletion plugins/generic/googleAnalytics
Open in desktop
Submodule googleAnalytics updated 2 files
+0 −4 GoogleAnalyticsPlugin.php
+0 −4 GoogleAnalyticsSettingsForm.php
2 changes: 1 addition & 1 deletion plugins/generic/staticPages
Open in desktop
Submodule staticPages updated 1 files
+0 −4 StaticPagesPlugin.php
2 changes: 1 addition & 1 deletion plugins/generic/tinymce
Open in desktop
Submodule tinymce updated 1 files
+0 −4 TinyMCEPlugin.php
2 changes: 1 addition & 1 deletion plugins/generic/webFeed
Open in desktop
Submodule webFeed updated 1 files
+0 −4 WebFeedPlugin.php
26 changes: 13 additions & 13 deletions plugins/importexport/native/filter/filterConfig.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,87 +17,87 @@
symbolic="monograph=>native-xml"
displayName="plugins.importexport.native.displayName"
description="plugins.importexport.native.description"
inputType="class::classes.submission.Submission[]"
inputType="class::APP\submission\Submission[]"
outputType="xml::schema(plugins/importexport/native/native.xsd)" />
<!-- Native XML monograph input -->
<filterGroup
symbolic="native-xml=>monograph"
displayName="plugins.importexport.native.displayName"
description="plugins.importexport.native.description"
inputType="xml::schema(plugins/importexport/native/native.xsd)"
outputType="class::classes.submission.Submission[]" />
outputType="class::APP\submission\Submission[]" />
<!-- Native XML author output -->
<filterGroup
symbolic="author=>native-xml"
displayName="plugins.importexport.native.displayName"
description="plugins.importexport.native.description"
inputType="class::classes.author.Author[]"
inputType="class::APP\author\Author[]"
outputType="xml::schema(plugins/importexport/native/native.xsd)" />
<!-- Native XML author input -->
<filterGroup
symbolic="native-xml=>author"
displayName="plugins.importexport.native.displayName"
description="plugins.importexport.native.description"
inputType="xml::schema(plugins/importexport/native/native.xsd)"
outputType="class::classes.author.Author[]" />
outputType="class::APP\author\Author[]" />
<!-- Publication Format native XML output -->
<filterGroup
symbolic="publication-format=>native-xml"
displayName="plugins.importexport.native.displayName"
description="plugins.importexport.native.description"
inputType="class::classes.publicationFormat.PublicationFormat"
inputType="class::APP\publicationFormat\PublicationFormat"
outputType="xml::schema(plugins/importexport/native/native.xsd)" />
<!-- Publication Format native XML input -->
<filterGroup
symbolic="native-xml=>PublicationFormat"
displayName="plugins.importexport.native.displayName"
description="plugins.importexport.native.description"
inputType="xml::schema(plugins/importexport/native/native.xsd)"
outputType="class::classes.publicationFormat.PublicationFormat[]" />
outputType="class::APP\publicationFormat\PublicationFormat[]" />
<!-- Submission file native XML output -->
<filterGroup
symbolic="SubmissionFile=>native-xml"
displayName="plugins.importexport.native.displayName"
description="plugins.importexport.native.description"
inputType="class::lib.pkp.classes.submissionFile.SubmissionFile"
inputType="class::PKP\submissionFile\SubmissionFile"
outputType="xml::schema(plugins/importexport/native/native.xsd)" />
<!-- Submission file native XML input -->
<filterGroup
symbolic="native-xml=>SubmissionFile"
displayName="plugins.importexport.native.displayName"
description="plugins.importexport.native.description"
inputType="xml::schema(plugins/importexport/native/native.xsd)"
outputType="class::lib.pkp.classes.submissionFile.SubmissionFile[]" />
outputType="class::PKP\submissionFile\SubmissionFile[]" />
<filterGroup
symbolic="monograph=>onix30-xml"
displayName="plugins.importexport.onix30.displayName"
description="plugins.importexport.onix30.description"
inputType="class::classes.submission.Submission"
inputType="class::APP\submission\Submission"
outputType="xml::schema(plugins/importexport/onix30/ONIX_BookProduct_3.0_reference.xsd)" />
<filterGroup
symbolic="publication=>native-xml"
displayName="plugins.importexport.native.displayName"
description="plugins.importexport.native.description"
inputType="class::classes.publication.Publication"
inputType="class::APP\publication\Publication"
outputType="xml::schema(plugins/importexport/native/native.xsd)" />
<filterGroup
symbolic="native-xml=>Publication"
displayName="plugins.importexport.native.displayName"
description="plugins.importexport.native.description"
inputType="xml::schema(plugins/importexport/native/native.xsd)"
outputType="class::classes.publication.Publication[]" />
outputType="class::APP\publication\Publication[]" />
<filterGroup
symbolic="chapter=>native-xml"
displayName="plugins.importexport.native.displayName"
description="plugins.importexport.native.description"
inputType="class::classes.monograph.Chapter[]"
inputType="class::APP\monograph\Chapter[]"
outputType="xml::schema(plugins/importexport/native/native.xsd)" />
<filterGroup
symbolic="native-xml=>chapter"
displayName="plugins.importexport.native.displayName"
description="plugins.importexport.native.description"
inputType="xml::schema(plugins/importexport/native/native.xsd)"
outputType="class::classes.monograph.Chapter[]" />
outputType="class::APP\monograph\Chapter[]" />

</filterGroups>
<filters>
Expand Down
2 changes: 1 addition & 1 deletion plugins/metadata/dc11/filter/filterConfig.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
symbolic="publicationFormat=>dc11"
displayName="plugins.metadata.dc11.publicationFormatAdapter.displayName"
description="plugins.metadata.dc11.publicationFormatAdapter.description"
inputType="class::classes.publicationFormat.PublicationFormat"
inputType="class::APP\publicationFormat\PublicationFormat"
outputType="metadata::APP\plugins\metadata\dc11\schema\Dc11Schema(PUBLICATION_FORMAT)" />
</filterGroups>
<filters>
Expand Down
4 changes: 0 additions & 4 deletions plugins/metadata/dc11/schema/Dc11Schema.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,3 @@ public function __construct()
parent::__construct(Application::ASSOC_TYPE_PUBLICATION_FORMAT);
}
}

if (!PKP_STRICT_MODE) {
class_alias('\APP\plugins\metadata\dc11\schema\Dc11Schema', '\Dc11Schema');
}