Bugfix/store recognisable session on registration#106
Open
quorauk wants to merge 3 commits into
Open
Conversation
quorauk
changed the title
jalada
reviewed
Sep 4, 2023
| # After the user has been signed up, we save the ip address in the | ||
| # DeviseRecognisable::RecognisableSession table. | ||
| def store_recognisable_details | ||
| return unless resource.persisted? |
Contributor
There was a problem hiding this comment.
Thanks @quorauk! I think the main question I'd be asking is if we have some social proof that this is the right way to add a hook after #create e.g. this guard is enough to confirm that we should be creating a RecogniseableSession. Do you have anything you can point to?
| def store_recognisable_details | ||
| return unless resource.persisted? | ||
| DeviseRecognisable::RecognisableSession.create!( | ||
| recognisable: resource_class.find_by(email: params[resource_name][:email]), |
Contributor
There was a problem hiding this comment.
Any reason why you can't just pass resource here?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Stores a recognisable session on registration
I noticed that sessions aren't stored when a user first registers, so the first actual sign in works without hitting Guard
I'm not particularly comfortable with this change, so let me know if it has some horrid gotchas i'm not aware of 😛
Ticket
#105
Before submitting have you:
After submitting remember to: