fix(export): Add robust fallback for PNG export scaling in offline mode #1197
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The PngExportController was experiencing scaling issues in offline mode where the 'Download selected frame as PNG' feature would always export at 1x scale regardless of the export scale setting. This commit adds a defensive getExportZoom_() method that: - First attempts to get zoom from the main ExportController (normal case) - Falls back to user settings if ExportController is unavailable - Defaults to 1x scale if all other methods fail This ensures consistent scaling behavior across both online and offline versions while maintaining backward compatibility. Fixes piskelapp#1135
|
is there a way that you could DM me about how to update it, or how to compile it? I'm new to this and I've been having this issue for a while now |
|
@Sebasss42 new to using git or github? Discord? |
|
New to github, but it seems the email it's censored for security I guess, it appears to me as *** @ *., you can add me on discord I'm @sebastudios |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PngExportController was experiencing scaling issues in offline mode where the 'Download selected frame as PNG' feature would always export at 1x scale regardless of the export scale setting.
This commit adds a defensive getExportZoom_() method that:
This ensures consistent scaling behavior across both online and offline versions while maintaining backward compatibility.
Fixes #1135