fix: nil pointer panic when framing an embedded @list value #92
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The issue was identified where a nil pointer panic occurred during the framing process when handling embedded @list values. This fix ensures proper handling of such scenarios to prevent the application from crashing unexpectedly. Closes: piprate#91 Co-authored-by: Alex Borodin <[email protected]> Signed-off-by: Alex Borodin <[email protected]> Signed-off-by: Michael Adler <[email protected]>
michaeladler
force-pushed
the
fix/framingAtList
branch
from
8b05a90 to
bfb0c96
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The issue was identified where a nil pointer panic occurred during the framing process when handling embedded @list values. This fix ensures proper handling of such scenarios to prevent the application from crashing unexpectedly.
Closes: #91
Basic example
Please see #91
Motivation
Framing must not
panic.Checks
make test