decorate choice line instead of just the symbol#203
Open
ishigo974 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the change
Make
active_colordecorate the whole line inmulti_selectinstead of just the radio button.Why are we doing this?
Improve readability.
Benefits
The list of selected items will be more readable, especially when the row is long and you want to be sure the selected item has a value written at the end of the choice string.
Drawbacks
Change of default behavior
Requirements
masterbranch?=> The documentation is already confusing, at it says
The answer provided by the user is also highlighted with the active color=> How am I supposed to choose the version and date?
This is the changelog I would write: