Set Prompt#messages to default on Questions initialization#201
Open
lucasmenezesds wants to merge 1 commit into
Open
Set Prompt#messages to default on Questions initialization#201lucasmenezesds wants to merge 1 commit into
lucasmenezesds wants to merge 1 commit into
Conversation
lucasmenezesds
force-pushed
the
allow-msg-as-key-arg
branch
3 times, most recently
from
cf563e4 to
6f901fa
Compare
lucasmenezesds
force-pushed
the
allow-msg-as-key-arg
branch
2 times, most recently
from
c73f44c to
c97541c
Compare
lucasmenezesds
force-pushed
the
allow-msg-as-key-arg
branch
from
c97541c to
79d8573
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the change
What does this Pull Request do?
The PR address the bug from the issue #197
Why are we doing this?
Any related context as to why is this is a desirable change.
To fix the bug of not being able to define custom messages from key arguments
Benefits
How will the library improve?
Fix the issue of not being able to define custom messages from key arguments, (previously was working only be block usage)
Drawbacks
Possible drawbacks applying this change.
Requirements
masterbranch?