Error on unknown comprehension-required attributes w/strict#276
Open
Error on unknown comprehension-required attributes w/strict#276
Conversation
JoTurk
reviewed
May 5, 2026
Comment on lines
+142
to
176
| var attrNames = map[AttrType]string{ | ||
| AttrMappedAddress: "MAPPED-ADDRESS", | ||
| AttrUsername: "USERNAME", | ||
| AttrErrorCode: "ERROR-CODE", | ||
| AttrMessageIntegrity: "MESSAGE-INTEGRITY", | ||
| AttrUnknownAttributes: "UNKNOWN-ATTRIBUTES", | ||
| AttrRealm: "REALM", | ||
| AttrNonce: "NONCE", | ||
| AttrXORMappedAddress: "XOR-MAPPED-ADDRESS", | ||
| AttrSoftware: "SOFTWARE", | ||
| AttrAlternateServer: "ALTERNATE-SERVER", | ||
| AttrFingerprint: "FINGERPRINT", | ||
| AttrPriority: "PRIORITY", | ||
| AttrUseCandidate: "USE-CANDIDATE", | ||
| AttrICEControlled: "ICE-CONTROLLED", | ||
| AttrICEControlling: "ICE-CONTROLLING", | ||
| AttrChannelNumber: "CHANNEL-NUMBER", | ||
| AttrLifetime: "LIFETIME", | ||
| AttrXORPeerAddress: "XOR-PEER-ADDRESS", | ||
| AttrData: "DATA", | ||
| AttrXORRelayedAddress: "XOR-RELAYED-ADDRESS", | ||
| AttrEvenPort: "EVEN-PORT", | ||
| AttrRequestedTransport: "REQUESTED-TRANSPORT", | ||
| AttrDontFragment: "DONT-FRAGMENT", | ||
| AttrReservationToken: "RESERVATION-TOKEN", | ||
| AttrConnectionID: "CONNECTION-ID", | ||
| AttrRequestedAddressFamily: "REQUESTED-ADDRESS-FAMILY", | ||
| AttrMessageIntegritySHA256: "MESSAGE-INTEGRITY-SHA256", | ||
| AttrPasswordAlgorithm: "PASSWORD-ALGORITHM", | ||
| AttrUserhash: "USERHASH", | ||
| AttrPasswordAlgorithms: "PASSWORD-ALGORITHMS", | ||
| AttrAlternateDomain: "ALTERNATE-DOMAIN", | ||
| AttrDtlsInStun: "DTLS-IN-STUN", | ||
| AttrDtlsInStunAck: "DTLS-IN-STUN-ACKNOWLEDGEMENT", | ||
| } |
Member
There was a problem hiding this comment.
not related, but I wonder if we should refactor this, and other Pion libraries so that IANA fields are automated in the CI (cron-job and check?), I did this for a rust SDP library I'm developing with @Juliapixel
https://github.com/meowdia/sphynx/blob/main/src/iana/generated.rs
meowdia/sphynx#6
Contributor
Author
There was a problem hiding this comment.
Yeah... what I have done in the past is to let depending packages (i.e. a TURN package) register methods and attributes
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #276 +/- ##
==========================================
- Coverage 66.43% 65.98% -0.45%
==========================================
Files 27 27
Lines 2124 2096 -28
==========================================
- Hits 1411 1383 -28
Misses 700 700
Partials 13 13
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Throws an error when encountering a unknown comprehension-required attribute in strict mode and log a warning in non-strict mode.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Throws an error when encountering a unknown comprehension-required attribute in strict mode and log a warning in non-strict mode.
(not sure if this is worth it even...)