Fix the module import workaround for Windows #174
Open
segevfiner wants to merge 3 commits intopinojs:mainfrom
Open
Fix the module import workaround for Windows
#174segevfiner wants to merge 3 commits intopinojs:mainfrom
segevfiner wants to merge 3 commits intopinojs:mainfrom
Conversation
Member
|
Can you look at the failing tests? |
segevfiner
commented
Jul 25, 2025
Author
segevfiner
left a comment
segevfiner
left a comment
There was a problem hiding this comment.
This project doesn't use a lock file and the latest version of @yao-pkg/pkg seems to not work with Node.js<=16. Something about not finding fs.promises.access.
Author
|
Hrmm the tests passed locally for me... So now we have some test that's only failing in CI? |
Member
|
I don't understand, this project CI is 18+. |
Author
|
The pkg.config.js said to build pkg binaries with older Node.js versions. I updated this in the PR. But now something else is failing only in CI. |
Member
|
@segevfiner please rebase this PR. |
Suprisingly we had pkg code actually hit the ERR_MODULE_NOT_FOUND on Node.js 22, but the workaround for Windows was missing there...
BTW it might be better to use `require('url').fileURLToPath()` for this?
segevfiner
force-pushed
the
windows-worker-workaround-fix
branch
from
215e4a4 to
d1adeba
Compare
Member
|
Can you add a test for this? |
Member
|
Does that test fails on Windows without this patch? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Suprisingly we had pkg code actually hit the ERR_MODULE_NOT_FOUND on Node.js 22, but the workaround for Windows was missing there...
BTW it might be better to use
require('url').fileURLToPath()for this?