Fix woke status overlap after snooze menu closes#4539
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
ApprovabilityVerdict: Approved CSS-only change adding Tailwind classes to fix visual overlap. No runtime logic affected - purely presentation layer adjustments with clear, limited scope. You can customize Macroscope's approvability policy. Learn more. |
|
Video of that bug is in #4537 issue |
Summary
WokeandSettlefrom overlapping after dismissing the snooze menuRoot cause
Closing the popover leaves focus on the snooze trigger. The action container stayed visible through
focus-within, while the status label was only hidden for hover or an open menu.Testing
pnpm --dir apps/web exec vp test run src/components/Sidebar.snooze.test.ts --project unit(7 tests)pnpm --filter @t3tools/web typecheckSidebarV2.tsx1andWokeresolved to opacity0Fixes #4537
Note
Fix status text overlap when snooze menu closes in sidebar
The woke status text in
SidebarV2Rowwas remaining visible while the snooze menu was open, causing an overlap. Adds agroup/actionsclass to the actions container in SidebarV2.tsx and hides the status text viagroup-focus-within/actions:opacity-0when focus is within the actions group, matching the existing hover-based hide behavior.Macroscope summarized 8e15a12.
Note
Low Risk
Two Tailwind classes on the sidebar card row; no logic or API changes.
Overview
Fixes Woke (and other top status labels) overlapping Settle on sidebar v2 card rows after the snooze popover is dismissed with an outside click.
The row actions area is now a
group/actionscontainer, and the status/time slot usesgroup-focus-within/actions:opacity-0so it stays hidden whenever focus remains inside that actions group—not only on row hover or whilesnoozeMenuOpenis true. That matches the existing behavior where closing the menu leaves focus on the snooze trigger and keeps the action buttons visible viafocus-within.Reviewed by Cursor Bugbot for commit 8e15a12. Bugbot is set up for automated code reviews on this repo. Configure here.