-
Notifications
You must be signed in to change notification settings - Fork 704
Add manage user access documentation for premium #21953
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: release-8.5
Are you sure you want to change the base?
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Summary of ChangesHello @zhoubasten, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a new documentation page dedicated to managing user access within the premium offering of TiDB Cloud. While the file structure is now in place, the content itself is currently a placeholder, signaling that further detailed information will be provided in subsequent updates. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
The pull request adds a new file tidb-cloud/premium/manage-user-access-premium.md with the content 'sdf'. This change introduces a new documentation file, but the content is minimal and lacks context. I have added a review comment to address the content of the file.
| @@ -0,0 +1 @@ | |||
| sdf | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The file contains only 'sdf'. Please provide meaningful content for this documentation page. Consider adding an overview, instructions, or relevant information about managing user access for premium users. Following the style guide 1, ensure clarity, simplicity, completeness, and readability.
Style Guide References
Footnotes
|
@zhoubasten: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
|
||
| # Identity Access Management | ||
|
|
||
| This document describes how to manage access to organizations, instances, roles and user profiles in TiDB Cloud. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| This document describes how to manage access to organizations, instances, roles and user profiles in TiDB Cloud. | |
| This document describes how to manage access to organizations, instances, roles and user profiles in TiDB Cloud Premium. |
| summary: Learn how to manage identity access in TiDB Cloud. | ||
| --- | ||
|
|
||
| # Identity Access Management |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| # Identity Access Management | |
| # Identity Access Management for TiDB Cloud Premium |
|
|
||
| ## Organizations and instances | ||
|
|
||
| TiDB Cloud provides a hierarchical structure based on organizations and instances to facilitate the management of TiDB Cloud users and TiDB instances. If you are an organization owner, you can create multiple TiDB instance in your organization. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| TiDB Cloud provides a hierarchical structure based on organizations and instances to facilitate the management of TiDB Cloud users and TiDB instances. If you are an organization owner, you can create multiple TiDB instance in your organization. | |
| TiDB Cloud Premium provides a hierarchical structure based on organizations and instances to facilitate the management of TiDB Cloud users and TiDB instances. If you are an organization owner, you can create multiple TiDB instances in your organization. |
| > **Tip:** | ||
| > - The default role at organization level is `Organization Viewer`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| > **Tip:** | |
| > - The default role at organization level is `Organization Viewer`. | |
| > **Tip:** | |
| > | |
| > - The default role at the organization level is `Organization Viewer`. |
| 5. If you only need assign the user an orgnization role, and not assign any instance roles or project roles, turn off the switch of **Add access for projects and instance**. | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| 5. If you only need assign the user an orgnization role, and not assign any instance roles or project roles, turn off the switch of **Add access for projects and instance**. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
reason: this option is not available now
| 6. Click **Invite**. Then the new user is successfully added into the user list. At the same time, an email is sent to the invited email address with a verification link. | ||
|
|
||
| 7. After receiving this email, the user needs to click the link in the email to verify the identity, and a new page shows. | ||
|
|
||
| 8. If the invited email address has not been signed up for a TiDB Cloud account, the user is directed to the sign-up page to create an account. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| 6. Click **Invite**. Then the new user is successfully added into the user list. At the same time, an email is sent to the invited email address with a verification link. | |
| 7. After receiving this email, the user needs to click the link in the email to verify the identity, and a new page shows. | |
| 8. If the invited email address has not been signed up for a TiDB Cloud account, the user is directed to the sign-up page to create an account. | |
| 5. Click **Invite**. Then the new user is successfully added into the user list. At the same time, an email is sent to the invited email address with a verification link. | |
| 6. After receiving this email, the user needs to click the link in the email to verify the identity, and a new page shows. | |
| 7. If the invited email address has not been signed up for a TiDB Cloud account, the user is directed to the sign-up page to create an account. |
|
|
||
| 2. In the left navigation pane, click **Organization Settings** > **Users**. | ||
|
|
||
| 3. On the **Users** page, click **...** > **Edit Permission** of the target member. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| 3. On the **Users** page, click **...** > **Edit Permission** of the target member. | |
| 3. On the **Users** page, click **...** > **Edit Role** in the row of the target member. |
|
|
||
| 2. In the left navigation pane, click **Organization Settings** > **Users**. | ||
|
|
||
| 3. On the **Users** page, click **...** > **Delete** in the row of the target member, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| 3. On the **Users** page, click **...** > **Delete** in the row of the target member, | |
| 3. On the **Users** page, click **...** > **Delete** in the row of the target member. |
First-time contributors' checklist
What is changed, added or deleted? (Required)
Which TiDB version(s) do your changes apply to? (Required)
Tips for choosing the affected version(s):
By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.
For details, see tips for choosing the affected versions.
What is the related PR or file link(s)?
Do your changes match any of the following descriptions?