-
Notifications
You must be signed in to change notification settings - Fork 705
Add maximum lifetime of connections #21895
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: release-8.5
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @sunxiaoguang, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request updates the TiDB Cloud serverless limitations documentation to include important information regarding database client connection lifetimes. The change aims to inform users about potential connection terminations for long-lived connections and provides a recommended starting point for connection lifetime settings to help prevent unexpected service impacts. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds an important limitation regarding the maximum lifetime of database connections for serverless clusters. My review includes a suggestion to correct a typo and rephrase the new content for better clarity and adherence to the documentation style guide, making the recommendation more direct for the user.
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
e1e1ef3 to
c88d517
Compare
c88d517 to
428018f
Compare
Signed-off-by: Xiaoguang Sun <[email protected]>
|
/gemini review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds documentation about configuring the maximum lifetime of connections to prevent disruptions. The changes are made in dev-guide-connection-parameters.md and tidb-cloud/serverless-limitations.md.
My review focuses on improving clarity and adhering to the documentation style guide. I've suggested rephrasing some sentences to use active voice and address the user directly, which makes the content more engaging and easier to understand. I also recommended a formatting change for consistency with the rest of the document and the style guide.
Overall, the changes are good and provide valuable information for users.
| <SimpleTab> | ||
| <div label="HikariCP"> | ||
|
|
||
| - **maxLifetime**: The maximum lifetime of a connection in the pool. | ||
|
|
||
| </div> | ||
|
|
||
| <div label="tomcat-jdbc"> | ||
|
|
||
| - **maxAge**: The maximum lifetime of a connection in the pool. | ||
|
|
||
| </div> | ||
|
|
||
| <div label="c3p0"> | ||
|
|
||
| - **maxConnectionAge**: The maximum lifetime of a connection in the pool. | ||
|
|
||
| </div> | ||
|
|
||
| <div label="dbcp"> | ||
|
|
||
| - **maxConnLifetimeMillis**: The maximum lifetime of a connection in the pool. | ||
|
|
||
| </div> | ||
| </SimpleTab> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
According to the style guide, options should be enclosed in backticks.1 To ensure consistency throughout the document, I suggest wrapping these parameter names in backticks.
<SimpleTab>
<div label="HikariCP">
- `maxLifetime`: The maximum lifetime of a connection in the pool.
</div>
<div label="tomcat-jdbc">
- `maxAge`: The maximum lifetime of a connection in the pool.
</div>
<div label="c3p0">
- `maxConnectionAge`: The maximum lifetime of a connection in the pool.
</div>
<div label="dbcp">
- `maxConnLifetimeMillis`: The maximum lifetime of a connection in the pool.
</div>
</SimpleTab>Style Guide References
Footnotes
-
The style guide specifies that options should be enclosed in backticks. ↩
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
|
LGTM |
Signed-off-by: Xiaoguang Sun <[email protected]>
First-time contributors' checklist
What is changed, added or deleted? (Required)
Which TiDB version(s) do your changes apply to? (Required)
Tips for choosing the affected version(s):
By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.
For details, see tips for choosing the affected versions.
What is the related PR or file link(s)?
Do your changes match any of the following descriptions?