Skip to content

tikv: update rocksdb.max-manifest-file-size default value #21689

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

tikv: update rocksdb.max-manifest-file-size default value #21689

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tikv-configuration-file.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1256,7 +1256,7 @@ Configuration items related to RocksDB
### `max-manifest-file-size`

+ The maximum size of a RocksDB Manifest file
+ Default value: `"128MiB"`
+ Default value: `"256MiB"`
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
+ Default value: `"256MiB"`
+ Default value: `"256MiB"`. Before v9.0.0, the default value is `"128MiB"`.

Copy link
Contributor Author

@glorv glorv Aug 29, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@qiancai We also want to change this default value in the incoming bugfix version of v7.5, v8.1 and v8.5. Thus, do we still need the "Before v9.0.0, the default value is "128MiB"" note? Sorry, I forget to add these versions in the affected verions.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, after the code changes in other releases are done, we need to update "Before v9.0.0, the default value is "128MiB" to something like "Before v7.5.5, v8.1.3, 8.5.4, and v9.0.0, the default value is "128MiB"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

+ Minimum value: `0`
+ Unit: B|KiB|MiB|GiB

Expand Down