Skip to content
This repository was archived by the owner on Mar 15, 2024. It is now read-only.

Report edge tupdate#69

Open
johannah-pik wants to merge 15 commits into
pik-piam:masterfrom
johannah-pik:reportEDGETupdate
Open

Report edge tupdate#69
johannah-pik wants to merge 15 commits into
pik-piam:masterfrom
johannah-pik:reportEDGETupdate

Conversation

@johannah-pik

Copy link
Copy Markdown
Contributor

-Bugfixes related to the embedding of the split liquids function
-Bugfix related to the Pass|Rail|non-HSR aggregation
-Aggregation of "World" region even if no regionSubsetList is provided
-Function was fully tested and compared to the reportEDGETransport function in remind2 so that it offers the same
functionality
Changes compared to reportEDGETransport in remind2 are:

  • units "bn pkm/yr" and "bn tkm/yr" were unified to "bn km/yr"
  • LDV Two-Wheelers and LDV 4-Wheelers were renamed to LDV Two Wheelers and LDV Four Wheelers
  • Additional variables are reported

@johannah-pik johannah-pik requested review from Loisel and fbenke-pik May 27, 2022 16:38
@codecov

codecov Bot commented May 27, 2022

Copy link
Copy Markdown

Codecov Report

Merging #69 (8f63468) into master (950bae0) will not change coverage.
The diff coverage is 0.00%.

❗ Current head 8f63468 differs from pull request most recent head 12b7b6f. Consider uploading reports for the commit 12b7b6f to get more accurate results

@@          Coverage Diff           @@
##           master     #69   +/-   ##
======================================
  Coverage    0.00%   0.00%           
======================================
  Files          11      11           
  Lines        1441    1523   +82     
======================================
- Misses       1441    1523   +82     
Impacted Files Coverage Δ
R/reportEDGETransport2.R 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 950bae0...12b7b6f. Read the comment docs.

Comment thread R/reportEDGETransport2.R Outdated
RegAggregation <- data.table(
aggr_reg = c("EUR", "EUR", "EUR", "EUR", "EUR", "EUR", "EUR", "EUR", "EUR", "NEU", "NEU"),
region = c("ENC", "EWN", "ECS", "ESC", "ECE", "FRA", "DEU", "UKI", "ESW", "NES", "NEN"))
aggr_reg = c("EUR", "EUR", "EUR", "EUR", "EUR", "EUR", "EUR", "EUR", "EUR", "NEU", "NEU"),

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these lists should be loaded from the GDX similar to what is done in the main reporting:
https://github.com/pik-piam/remind2/blob/master/R/convGDX2MIF.R#L28

Comment thread R/reportEDGETransport2.R Outdated
@Loisel

Loisel commented May 31, 2022

Copy link
Copy Markdown
Contributor

another question: why do we need to unify tkm/pkm -> km? Since these values mean quite different things they should in my opinion be reflected in the unit.

@johannah-pik

Copy link
Copy Markdown
Contributor Author

I changed it for compatibility with REMIND compareScenarios2 and I think it makes things a lot easier if you do not have different units for freight and passenger energy services as long as our definition is clear on that (vkm are still vkm and km is either tkm for freight or pkm for passenger)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants