Add segment annotation mode to edit_physio() - #108
Open
me-pic wants to merge 4 commits into
Open
Conversation
for more information, see https://pre-commit.ci
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #
[WIP]
I modified the peakdet codebase a moment ago to be able to annotate segments (save the onset and offset of segments) during the manual editing (
operations.edit_physio) for my personal use case. I'm doing that PR in case that could be a feature useful for others!Proposed Changes
annotate_segments()function and modify existing functions ineditor.pyto be able to annotate segments in the interactive viewersegmentsproperty to be able to store the onset and offset of selected segments in thesegmentsattribute of aPhysioinstance, and in the metadataA few comments/questions:
.pre-commit-config.yamlfile and specify the python version to be able to run the pre-commit hooks. Ideally I guess the .pre-commit-config.yaml would not include it, so if anybody wants to discuss the error I got before that change, it would be great!physio_edit_segment.giffor the documentation (the file size is smaller than the other gif already included i.e.physio_edit.gif).make htmlin thedocs/subdirectory). There was a problem with L118 in conf.py. I ended up just commenting that line for the sake of testing the rendering of the modified doc. I would have to investigate a bit more on that, but it's also been a while since the last rtd build (5 years ago) and I'm wondering if the problem is not only local.Change Type
bugfix(+0.0.1)minor(+0.1.0)major(+1.0.0)refactoring(no version update)test(no version update)infrastructure(no version update)documentation(no version update)otherChecklist before review