feat(go): Bubble up directories looking for config #SCD-148 #985
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR implements a feature to search for configuration files by traversing up the directory tree from the current working directory. Instead of only checking the current working directory for config files, the code now walks up parent directories until it finds a config file or reaches the root directory.
Key Changes:
- Modified
configPath()function to iteratively search parent directories for configuration files - Added test case
TestConfigPath_ConfigInParentDirto verify parent directory config discovery - Updated test data paths to reflect new directory structure (e.g.,
testdata/config_filesandtestdata/empty2)
Reviewed changes
Copilot reviewed 2 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| clients/go/config.go | Added directory tree traversal logic to search parent directories for config files |
| clients/go/config_test.go | Added new test for parent directory config discovery and updated existing test paths |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
theSoenke
approved these changes
Dec 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://phrase.atlassian.net/browse/SCD-148
phrase/phrase-cli#100