This repository was archived by the owner on Feb 14, 2021. It is now read-only.
allowing namespaces containing Spec like Specification (fix #5)#6
Open
brunoroux wants to merge 1 commit intophpspec:masterfrom
Open
allowing namespaces containing Spec like Specification (fix #5)#6brunoroux wants to merge 1 commit intophpspec:masterfrom
brunoroux wants to merge 1 commit intophpspec:masterfrom
Conversation
ghost
mentioned this pull request
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm not sure this is the most elegant solution but I couldn't use any preg_replace because it made specs fail. Couldn't figure out why.
So i switched back to some good old str_replace.
From what I understand, Spec has to be replaced in 2 cases :
Every other occurence should be left untouched