This repository was archived by the owner on Feb 14, 2021. It is now read-only.
Replaced custom container with a stub#4
Merged
jakzal merged 1 commit intophpspec:masterfrom Nov 3, 2013
jakzal:container-stub
Merged
Replaced custom container with a stub#4jakzal merged 1 commit intophpspec:masterfrom jakzal:container-stub
jakzal merged 1 commit intophpspec:masterfrom
jakzal:container-stub
Conversation
jakzal
added a commit
that referenced
this pull request
Nov 3, 2013
Replaced custom container with a stub
Member
Author
|
I merged it even though there's a risk we'll abandon this approach, because it only simplifies the current approach. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The trick with custom container is no longer required with the latest phpspec versions. This PR makes calls to the container a bit more natural, since instead of calling
set()we can now simply stub it:However, I'm not sure if the approach with container as a property is the road we want to continue going (see #3).