Open
Conversation
petk
approved these changes
May 22, 2019
Member
|
Sounds ok with me... |
Member
|
I cannot merge this anymore because I left the web team so you're free to change the project according to your likings and your workflow. Thanks. |
Member
|
bugs.php.net is no longer really used, and hence, we're sunsetting it. Due to that, I don't think it makes sense to merge this patch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently mocking (and testing) anything that makes HTTP requests is pretty much impossible due to the tight coupling of
file_get_contents()calls.This PR adds an HTTP client (and interface) to make this possible / easier. While also providing a uniform way to make HTTP requests (including error handling and responses).
Todo: when the need arises implement file uploads, but from a quick look through the code base I did see see the need for it yet.
Todo2: when agreed that this PR is a useful addition move away from the direct
fgc()calls and implement the HTTP client calls instead.