Zend: expose zend_throw_exception_zstr() API and use it #20547
+27
−32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
I don't mind the name of the function - it does what it should. Good improvement. |
Member
|
That CI failure looks suspicious... |
Member
|
I think you can just merge ae0bad5 until you figure out... |
As having the message as a zend_string is not uncommon
Girgias
force-pushed
the
exception-error-formating-refacto
branch
from
10bdd44 to
6c1e82f
Compare
Member
Author
Arguably the current error message is wrong because it is being truncated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This does prevent some strlen() computations, but the API naming is not idea. And not sure if this should be persued.