Skip to content

Conversation

@StephenWall
Copy link
Contributor

…output in a backwards compatible way.

Fixes #20310

@StephenWall StephenWall requested a review from bukka as a code owner October 27, 2025 17:31
@StephenWall StephenWall force-pushed the critical branch 5 times, most recently from 97e7639 to 208d4d4 Compare October 30, 2025 21:17
@bukka
Copy link
Member

bukka commented Dec 9, 2025

This looks slightly strange. How about a new field criticalExtension that would contain string array of critical extension names?

@StephenWall
Copy link
Contributor Author

This looks slightly strange. How about a new field criticalExtension that would contain string array of critical extension names?

To clarify, $info['extensions'] is unchanged and a new $info['criticalExtensions'] has a list of the names of critical extensions?

$info['extensions'] => array (
  'basicConstraints' => 'CA:FALSE',
  ...
)

$info['criticalExtensions'] => array(
  'basicConstraints'
)

@bukka
Copy link
Member

bukka commented Dec 9, 2025

Yes, exactly.

@StephenWall
Copy link
Contributor Author

OK, self test runs cleanly, I think this is set.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

No critical extension indication in openssl_x509_parse() output.

2 participants