Skip to content

Conversation

@CViniciusSDias
Copy link
Contributor

Simplifiying the "A simple tutorial" page by removing the Apache and MySQL pre-requisites and using php's builtin server

… and MySQL pre-requisites and using php's builtin server
Copy link
Member

@TimWolla TimWolla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. I have some comments, but this definitely looks like an improvement to me.

@TimWolla TimWolla requested a review from Girgias October 24, 2025 21:09
Copy link
Member

@TimWolla TimWolla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Given the prominent spot of this page, I'd like to see another approval before merging.

Comment on lines 30 to 50
<para>
<example>
<info><title>Our first PHP script: <filename>hello.php</filename></title></info>
<programlisting role="php">
<![CDATA[
<?php
echo "Hello World!";
?>
]]>
</programlisting>
<simpara>
Using your terminal, navigate to the directory containing this file and
start a development server with the following command:
</simpara>
<programlisting role="shell">
<![CDATA[
php -S localhost:8000
]]>
</programlisting>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does the "example" tag+title even provide any benefit?

Maybe just moving all of it into the normal flow is better? But I don't have strong opinions about this and the new text is an improvement over the current one.

@kamil-tekiela kamil-tekiela merged commit 876557a into php:master Oct 31, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants