Skip to content

Improve getNodeName #68

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Improve getNodeName #68

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
396ffdc
Improve getNodeName
szepeviktor Mar 6, 2023
bf360e0
debug
szepeviktor Mar 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion visitor.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -307,7 +307,9 @@ public function enterNode(Node $node)

private static function getNodeName(Node $node): string
{
if ((($node instanceof Function_) || ($node instanceof ClassMethod) || ($node instanceof Class_)) && $node->name instanceof Identifier) {
if ($node instanceof Function_ || $node instanceof ClassMethod || ($node instanceof Class_ && $node->name instanceof Identifier)) {
\PHPStan\dumpType($node);
\PHPStan\dumpType($node->name);
return $node->name->name;
}

Expand Down