Fix phx.new.web generator referencing Ecto - #6808
Merged
SteffenDE merged 1 commit intoSep 1, 2026
Merged
Conversation
Contributor
Author
|
Assisted by Google Antigravity CLI / Gemini 3.7 Flash. |
Member
|
@rhcarvalho can you rebase please? |
The `phx.new.web` task is documented to create a bare Phoenix web project without database integration inside an umbrella. However, because it did not pass `--no-ecto`, it inherited the generator's default `ecto: true` setting, generating invalid references to a non-existent `<App>.Repo` and `<App>.DataCase`. This passes `--no-ecto` by default when running `phx.new.web`. We also take the opportunity to tighten test assertions and `mix format` the touched files.
rhcarvalho
force-pushed
the
fix-phx-new-web-defaults
branch
from
September 1, 2026 12:58
e36bb2c to
ffab8ca
Compare
Contributor
Author
|
Rebased |
Member
|
Good, we might revisit adding a |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
phx.new.webtask is documented to create a bare Phoenix web project without database integration inside an umbrella. However, because it did not pass--no-ecto, it inherited the generator's defaultecto: truesetting, generating invalid references to a non-existent<App>.Repoand<App>.DataCase.This passes
--no-ectoby default when runningphx.new.web.Fixes #5690.
Closes #5691.