Force critical conflict and cleanup regression conditions - #7
Open
jeregrine wants to merge 1 commit into
Open
Conversation
This was referenced Sep 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Sequential registrations do not guarantee equal timestamps, and increasing shard count does not guarantee late discovery runs after another shard's cleanup. The existing scenarios can pass without exercising the specific regressions they describe.
Fix
Add focused protocol regressions with real remote PIDs and deliberately equal timestamps. Exercise both PID orderings through batched replication and snapshot merge, checking the exact winner, loser exit reason, eviction event, and index consistency. Separate Group instances prevent discovery or rebroadcast from resolving the conflict before the input under examination arrives.
Explicit mailbox barriers schedule shard-zero cleanup, late discovery on shard one, and shard-one cleanup. Exercise nodedown and monitor DOWN independently, keeping the peer alive so an unrelated automatic cleanup signal cannot mask a broken handler.
Retain the existing real partition-heal and node-death scenarios as end-to-end coverage, with descriptions that distinguish them from the deterministic regressions.
Supporting information
No production behavior changes. The deliberate signal delivery complements real network-failure scenarios; it is not a simulation of the entire distribution runtime.