Assert persisted state and actual lifecycle recovery in tests - #31
Open
jeregrine wants to merge 1 commit into
Open
Assert persisted state and actual lifecycle recovery in tests#31jeregrine wants to merge 1 commit into
jeregrine wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Several sync and recovery cases pass without exercising their advertised behavior: sync checks only read process memory, a discovery failure case injects no failure, and an expiry case only asserts that stored data is a map.
Fix
Assert persisted state for call, cast, and info sync boundaries. Replace the ineffective expiry scenario with paired active/expired foreign-claim cases against a real supervisor, checking recovered state, ownership, and claim cleanup.
Remove redundant no-fault smoke cases and strengthen the existing injected discovery-crash regression to prove that the next cycle actually recovers a permanent server with its stored state.
Supporting information
This changes test scenarios and assertions only. The claim fixtures explicitly make the old owner orphaned and permanent, so claim expiry is the eligibility condition under examination.