Convert build system from make+bash to meson - #262
Draft
NHOrus wants to merge 20 commits into
Draft
Conversation
Owner
|
Thanks for taking the initiative! The main reason I'm using plain gnu make is to avoid the dependency on a specific build system. My take on downstream modifications is that I'd rather provide all customization that's needed as upstream features. Is there anything you're missing specifically? The package should currently compile just fine on anything that provides a working pkg-config. |
Contributor
Author
|
Frankly, no. I just like meson more than plain GNU Make. And find it more readable. |
Contributor
Author
|
Again, this PR is for... education, other two are for actual inclusion. |
Need to add file handlers, configuration options to parity
Descriptions may need to be edited.
Don't use the compiler flag, meson generates config file from configuration
Naive translation of code from GNUmakefile, works in manual testing
First successful, working build!
Reorder steps so all dependencies are done together
Not the most elegant, but dependency discovery is cached
Format meson files
Basic functionality is done. Uninstall works by calling `ninja uninstall` in build dir.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I feel that having to reimplement feature detection, configuration and package discovery in GNU Make, in addition of doing everything else pqiv does, is a bad idea. Better to leave it to generic solutions that are easy for downstream to understand and modify.
To do: